ref(node): Streamline lru-memoizer instrumentation#21350
Merged
Conversation
nicohrubec
force-pushed
the
nh/streamline-lrumemoizer
branch
3 times, most recently
from
edab9dc to
2a2df78
Compare
Vendor the upstream OTel unit tests and clean out the dead config passthrough. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
nh/streamline-lrumemoizer
branch
from
2a2df78 to
811b01c
Compare
nicohrubec
requested review from
JPeer264 and
andreiborza
and removed request for
a team
nicohrubec
changed the title
nicohrubec
commented
Jun 8, 2026
| @@ -0,0 +1,112 @@ | |||
| /* | |||
Member
Author
There was a problem hiding this comment.
mhm on second thought: since we are gonna rewrite the instrumentation to orchestrion soon, maybe porting the unit tests might actually be too close to the implementation to make sense? as in we probably will have to rewrite these then anyways when porting to orchestrion?
Member
There was a problem hiding this comment.
The tests themselves test instrumentation details right? I think it's fine, we'll only have to swap out the patching mechanism I guess, unless I'm missing something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
@opentelemetry/instrumentation-lru-memoizer:configconstructor param (the SDK always constructs it with no config).Fixes #20735